[U-Boot] [PATCH V5] ARM: mx6: Add support for Kosagi Novena

[Nikolay Dimitrov]

Hi Marek,

On 10/09/2014 02:59 AM, Marek Vasut wrote:
> On Wednesday, October 08, 2014 at 05:35:44 PM, picmaster at mail.bg wrote:
>> Hi Sean,
>
> Hi all,
>
>> ----- Цитат от Sean Cross (xobs at kosagi.com), на 08.10.2014 в 10:47 -----
>>
>>> On 08/10/2014 05:55, Nikolay Dimitrov wrote:
>>>> Hi Marek,
>>>>
>>>> I'm marking only the critical issues that are left unfixed from
>>>> previous conversations, to speed-up the process a little bit.
>>>> I'll send later patches for the non-critical issues to spare you the
>>>> extra work (and I'm sure my constructive criticism is already boring
>>>>
>>>> :D ).
>>>>
>>>> On 10/06/2014 07:02 PM, Marek Vasut wrote:
>>>>> +#define NOVENA_USB_HUB_RESET    IMX_GPIO_NR(7, 12)
>>>>
>>>> ...
>>>>
>>>>> +/*
>>>>> + * USB
>>>>> + */
>>>>> +#ifdef CONFIG_USB_EHCI_MX6
>>>>> +int board_ehci_hcd_init(int port)
>>>>> +{
>>>>> +    /* Reset USB hub */
>>>>> +    if (port == 1) {
>>>>> +        gpio_set_value(NOVENA_USB_HUB_RESET, 0);
>>>>> +        mdelay(2);
>>>>> +        gpio_set_value(NOVENA_USB_HUB_RESET, 1);
>>>>> +    }
>>>>> +    return 0;
>>>>> +}
>>>>> +#endif
>>>>
>>>> As we previously discussed, this pin definition conflicts with
>>>> NOVENA_PCIE_POWER_ON_GPIO (GPIO7_IO12 is connected to PCIE_PWRON), so
>>>> by asserting it, you'll turn-off the wrong sub-system.
>>>>
>>>> Currently the USB hub is reset only by system reset (RESETBMCU
>>>> asserted by the PMIC). I don't see how the CPU can selectively reset
>>>> the USB hub via a GPIO, so it would be better to remove the reset code.
>>>>
>>>> @Sean - can you please confirm/reject this finding?
>>
>> @Sean: Do you have any comments on USB hub reset stuff? Should we ditch
>> entirely the reset code, or should we modify it somehow to work properly?
>
> OK, so it's just this USB that remains, right ?

That's correct.

There are a bunch of non-critical things for fixing also, but we'll 
negotiate later about them :D.

Regards,
Nikolay