[U-Boot] [PATCH] tegra: gpio: fix null label regression

[Simon Glass]

Hi Marcel,

On 10 October 2014 09:53, Marcel Ziswiler <marcel at ziswiler.com> wrote:
> Hi Simon
>
> On Fri, 2014-10-10 at 09:42 -0600, Simon Glass wrote:
>> OK, is it possible to stop calling the function with NULL instead?
>
> Yes, sure. Remember
>
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/198189
>
>> That is a bug IMO.
>
> Well, that's what I tried to find out digging through the header file.
> But I could not quite make out a place where it would state that. Anyway
> crashing like that seems rather harsh, not?

Well you fixed that bug. Are there any others? Checking for obviously
invalid args is not typically done due to the code overhead (e.g try
to use assert() which is compiled out in production code).

Regards,
Simon