[U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

Simon Glass sjg at chromium.org
Mon Oct 13 07:14:18 CEST 2014


Hi Jeroen,

On 12 October 2014 10:13, Jeroen Hofstee <jeroen at myspectrum.nl> wrote:

> Hello Hans,
>
> On 12-10-14 12:25, Hans de Goede wrote:
>
>> Hi,
>>
>> This one seems to have fallen through the cracks.
>>
>> Regards,
>>
>> Hans
>>
>>  (for U-boot)
>
> nope, you replace an innocent warning (_might_ be) with
> bad code, without any comment it is just because gcc failed
> to recognize it is fine. Nor did you respond to the suggestion
> if it helps gcc to recognize that if the two booleans are merged
> into a single one. [or even split it in an if () if ()]. With this patch
> you prevent any serious warning in case the variable is actually
> used but not initialized, which is even worse if you ask me.
>

That is a pretty acerbic tone to take on the U-Boot list at least. Are you
two drinking buddies or something?

Regards,
Simon


More information about the U-Boot mailing list