[U-Boot] [PATCH] dm: serial: Fix breakage due to stdio changes

Simon Glass sjg at chromium.org
Tue Oct 14 11:48:41 CEST 2014


Hi Tom,

On 14 October 2014 10:50, Tom Rini <trini at ti.com> wrote:
> On Tue, Oct 14, 2014 at 09:34:38AM +0200, Simon Glass wrote:
>> Hi Tom,
>>
>> On 10 October 2014 05:06, Simon Glass <sjg at chromium.org> wrote:
>> > Commit 32d0192 broke the sandbox build - fix it.
>> >
>> > Signed-off-by: Simon Glass <sjg at chromium.org>
>> > ---
>> >
>> >  drivers/serial/serial-uclass.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
>> > index fd010ca..6dde4ea 100644
>> > --- a/drivers/serial/serial-uclass.c
>> > +++ b/drivers/serial/serial-uclass.c
>> > @@ -198,7 +198,7 @@ static int serial_pre_remove(struct udevice *dev)
>> >  #ifdef CONFIG_SYS_STDIO_DEREGISTER
>> >         struct serial_dev_priv *upriv = dev->uclass_priv;
>> >
>> > -       if (stdio_deregister_dev(upriv->sdev), 0)
>> > +       if (stdio_deregister_dev(upriv->sdev, 0))
>> >                 return -EPERM;
>> >  #endif
>>
>> Can you please pick up this one?
>
> Ah, wait!
> Author: Hans de Goede <hdegoede at redhat.com>
> Date:   Fri Oct 10 18:30:17 2014 +0200
>
>     serial-uclass: Fix compilation error
>
>     Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> So we're good to go still.

Thanks, sorry I missed that.

Regards,
Simon


More information about the U-Boot mailing list