[U-Boot] [U-boot] [Patch v4 2/6] keystone2: clock: add K2L clock definitions and commands

[Tom Rini]

On Mon, Oct 20, 2014 at 06:41:29PM +0300, Ivan Khoronzhuk wrote:
> On 10/20/2014 06:13 PM, Tom Rini wrote:
> >On Wed, Oct 15, 2014 at 02:55:28AM +0300, Ivan Khoronzhuk wrote:
> >
> >>From: Hao Zhang <hzhang at ti.com>
> >>
> >>This patch adds clock definitions and commands to support Keystone II
> >>K2L SOC.
> >>
> >>Acked-by: Vitaly Andrianov <vitalya at ti.com>
> >>Signed-off-by: Hao Zhang <hzhang at ti.com>
> >>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk at ti.com>
> >[snip]
> >>diff --git a/arch/arm/cpu/armv7/keystone/cmd_clock.c b/arch/arm/cpu/armv7/keystone/cmd_clock.c
> >>index d97c95b..9204887 100644
> >>--- a/arch/arm/cpu/armv7/keystone/cmd_clock.c
> >>+++ b/arch/arm/cpu/armv7/keystone/cmd_clock.c
> >>@@ -72,6 +72,13 @@ U_BOOT_CMD(
> >>  	"<pa|ddr3> <mult> <div> <OD>\n"
> >>  );
> >>  #endif
> >>+#ifdef CONFIG_SOC_K2L
> >>+U_BOOT_CMD(
> >>+	pllset, 5,      0,      do_pll_cmd,
> >>+	"set pll multiplier and pre divider",
> >>+	"<pa|arm|ddr3> <mult> <div> <OD>\n"
> >>+);
> >>+#endif
> >>  int do_getclk_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> >>  {
> >>@@ -101,6 +108,9 @@ U_BOOT_CMD(
> >>  #ifdef CONFIG_SOC_K2E
> >>  	"See the 'enum clk_e' in the clock-k2e.h for clk indexes\n"
> >>  #endif
> >>+#ifdef CONFIG_SOC_K2L
> >>+	"See the 'enum clk_e' in the clock-k2l.h for clk indexes\n"
> >>+#endif
> >>  );
> >I'm not going to block on all of this duplication, but we need to think
> >how to do this cleaner so that the next K2 variant doesn't expand this
> >mess further.  Thanks!
> >
> 
> I'll correct it to one line:
> "See the 'enum clk_e' in the clock-k2*.h for clk indexes\n"

That helps the second hunk, but still leaves the first.  At some point,
even, we shouldn't say "go modify file foo" in the binary, that belongs
in board documentation.  Like I said, this needs a little bit of
thinking.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141020/5863a505/attachment.pgp>