[U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions

Tom Rini trini at ti.com
Mon Oct 20 21:17:13 CEST 2014


On Mon, Oct 20, 2014 at 09:59:44AM -0500, Andrew Ruder wrote:

> Currently this argument is not used.  To eventually support multiple
> DM9000's these public-facing functions will need a new argument - the
> ethernet device.  Fix-up the one board using this part of the DM9000
> API.  Compile-tested only.
[snip]
> -void dm9000_read_srom_word(int offset, u8 *to)
> +void dm9000_read_srom_word(struct eth_device *dev, int offset, u8 *to)
>  {
> +	(void)dev;

You shouldn't have to add this to avoid a warning I think.  And frankly,
if it does for some reason since 3/3 makes use of dev, I'm OK with a
bisect adding a trivial warning like this, rather than do compiler
games.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141020/af3ddb84/attachment.pgp>


More information about the U-Boot mailing list