[U-Boot] [PATCH v10 14/14] RFC: Deprecate MAKEALL

[Tom Rini]

On Wed, Oct 22, 2014 at 09:11:21AM -0600, Simon Glass wrote:
> Hi Wolfgang,
> 
> On 22 October 2014 02:33, Wolfgang Denk <wd at denx.de> wrote:
> > Dear Tom,
> >
> > In message <20141014081724.GF25506 at bill-the-cat> you wrote:
> >>
> >> No, not yet.  I am going to mention in the release notes that we're
> >> going to strongly start thinking about deleting MAKEALL.  We can pick up
> >> the deprecation patch early in the next merge window.
> >
> > Can we please keep at least some script (as a wrapper around
> > buildman?) that keeps the old user interface in place?
> >
> > I frequently use "git bisect run MAKEALL <board> ...", and it would
> > be nice if we could keep this working even in newer versions of the
> > code.
> >
> > Or is there a similar alternative command that works with identical
> > parameters for - say - all versions of the last two years or so?
> 
> Unfortunately there is not really an equivalent, and buildman only recently
> 
> - sets its return code correctly
> - supports building the current tree (previously it required a branch
> name for the commit to build)
> 
> During development of buildman/patman I used to keep a separate tree.
> Then you can run the latest buildman from that tree using you current
> directory for the bisect.
> 
> I could perhaps look at adjusting MAKEALL to call buildman if that
> solution isn't good enough (this will work assuming that buildman has
> been set up with toolchains, etc.). Still I think a deprecation
> warning is a good start.

I think for Wolfgang's case that might just have to be handled with an
external wrapper, translating all of the ways to run MAKEALL into
buildman, reliably, would be a bit of an undertaking.  But for bisect
run:

if [ -x ./MAKEALL ]; then
  ./MAKEALL $@
else
  ./tools/buildman/buildman $@
fi

And "board" will get built, one way or another, defaulting to MAKEALL
while it's still here.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141022/5980f02b/attachment.pgp>