[U-Boot] [PATCH 0/7] dm-serial: bug fix and refactoring and conversion of Uniphier serial

Simon Glass sjg at chromium.org
Thu Oct 23 05:24:22 CEST 2014


HI Masahiro,

On 22 October 2014 03:13, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
>
> 1/7: bug fix of console serial
> 2/7 - 3/7: cleanup
> 4/7: prepare some Kconfig entries
> 5/7 - 7/7: convert UniPhier serial driver and some cleanups
>
> Simon,
> As I promised before, here is the conversion of
> driver/serial/serial_uniphier.c into driver model.
>
> It has taken some time because I have had a hard time
> to find 1/7 bug.
>
> BTW, lowlevel-debug patches were really helpful
> to debug driver-model serial.
> http://patchwork.ozlabs.org/patch/384612/
> http://patchwork.ozlabs.org/patch/384615/
> http://patchwork.ozlabs.org/patch/384613/
> http://patchwork.ozlabs.org/patch/384611/

Did you take a look at the idea of having standard names for the
'init' and 'putc' functions in the UART drivers? We could make that
with with DM at least. This would require each driver to have a
low-level 'init' function which just takes a UART address, and a
'putc' function that takes an address and a character.

Regards,
Simon


More information about the U-Boot mailing list