[U-Boot] [PATCH] arm: socfpga: Add I2C support to SoCFPGA

[Stefan Roese]

Hi Marek, Hi Heiko!

On 21.10.2014 08:44, Heiko Schocher wrote:
>>>   /*
>>> + * I2C support
>>> + */
>>> +#define CONFIG_HARD_I2C
>
> No ... do not add this define please.
>
>>> +#define CONFIG_DW_I2C
>>> +#define CONFIG_I2C_MULTI_BUS
>>
>> I presume this should be converted to CONFIG_SYS_I2C framework instead
>> of using
>> this I2C multibus horror, no?
>
> ... Yes, please!
>
> Which i2c driver does socfpga use? If it is the
> "drivers/i2c/designware_i2c.c"
> driver, please convert it to the "CONFIG_SYS_I2C" framework.

Yes. Its the designware driver.

I wanted to make this I2C support for SoCFPGA least intrusive. But I see 
your point. Moving this driver to the new I2C framework makes sense.

> You may also take a look into Simons RFC patches, which introduce
> DM model:
> http://lists.denx.de/pipermail/u-boot/2014-October/191497.html

This seems a bit too early for me.

I'll try to find some time to move to the "CONFIG_SYS_I2C" framework...

Thanks,
Stefan