[U-Boot] [PATCH] dm: move platform data headers to include/dm/platform_data

Simon Glass sjg at chromium.org
Thu Oct 23 21:02:18 CEST 2014


Hi Masahiro,

On 23 October 2014 12:55, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> Hi Simon,
>
>
> 2014-10-24 3:31 GMT+09:00 Simon Glass <sjg at chromium.org>:
>>> diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c
>>> index f77ff48..a56777b 100644
>>> --- a/board/compulab/cm_fx6/cm_fx6.c
>>> +++ b/board/compulab/cm_fx6/cm_fx6.c
>>> @@ -15,7 +15,7 @@
>>>  #include <netdev.h>
>>>  #include <fdt_support.h>
>>>  #include <sata.h>
>>> -#include <serial_mxc.h>
>>> +#include <dm/platform_data/serial_mxc.h>
>>
>> Can we please put dm below asm in the sort order?
>
> Sure, I will send v2,
> but could you teach me how header files should generally be sorted?
>
> Do you mean "global" to "local" order?
> I just want to learn your lesson.

Well this is what I do. I'm not sure if it is documented anywhere, or
even if everyone agrees.

common.h
a-z for things in include/
<asm/xxx.h>
<asm/arch/yyy.h>
<dm/...>
<linux/...>
"a-z local-things.h"

Regards,
Simon


More information about the U-Boot mailing list