[U-Boot] [Patch] mmc: fsl_esdhc: fix f_max retrieval during init

Stefano Babic sbabic at denx.de
Fri Oct 24 13:35:42 CEST 2014


Hi Markus,

On 24/10/2014 11:44, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel at tq-group.com>
> 
> for multi instance API we use struct fsl_esdhc_cfg to
> pass the clock rate. Do not set f_max from global data,
> since this is wrong for multi instance case.
> 
> Signed-off-by: Markus Niebel <Markus.Niebel at tq-group.com>
> ---
>  drivers/mmc/fsl_esdhc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 2640607..8a1a461 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -610,7 +610,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
>  #endif
>  
>  	cfg->cfg.f_min = 400000;
> -	cfg->cfg.f_max = min(gd->arch.sdhc_clk, 52000000);
> +	cfg->cfg.f_max = min(cfg->sdhc_clk, 52000000);
>  
>  	cfg->cfg.b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;

Just a note for PowerPC users: as far I can see, PowerPC boards should
continue to work, because fsl_esdhc_mmc_init() backup gd->arch.sdhc into
cfg->sdhc_clk. Anyway, it would be not bad if patch could be tested even
on those boards.

Acked-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list