[U-Boot] [PATCH 2/3] net: macb: enable GMAC IP without GE feature support

[Andreas Bießmann]

Hi Bo,

On 16.09.14 09:57, Bo Shen wrote:
> The User Register in GMAC IP is used to select interface type.
> When with GE feature, it is used to select interface between
> RGMII and GMII. If without GE feature, it is used to select
> interface between MII and RMII.
> 
> Signed-off-by: Bo Shen <voice.shen at atmel.com>
> ---
> 
>  drivers/net/macb.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 01a94a4..369d155 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -574,7 +574,13 @@ static int macb_init(struct eth_device *netdev, bd_t *bd)
>  	macb_writel(macb, TBQP, macb->tx_ring_dma);
>  
>  	if (macb_is_gem(macb)) {
> -#ifdef CONFIG_RGMII
> +		/*
> +		 * When the GMAC IP with GE feature, this bit is used to
> +		 * select interface between RGMII and GMII.
> +		 * When the GMAC IP without GE feature, this bit is used
> +		 * to select interface between RMII and MII.
> +		 */
> +#if defined(CONFIG_RGMII) || defined(CONFIG_RMII)
>  		gem_writel(macb, UR, GEM_BIT(RGMII));
>  #else
>  		gem_writel(macb, UR, 0);
> 

looks good

Best regards

Andreas Bießmann