[U-Boot] [PATCH] e1000: fix sw fw sync on igb i210/i211

[Marcel Ziswiler]

On Thu, 2014-10-23 at 01:12 -0700, Tim Harvey wrote:
> I've never been able to get e1000_swfw_sync_acquire() to not timeout
> on the boards with i210 devices that I have (IMX6 with 2x i210
> programmed as 8086:1533 using int phys).

Ah, OK. I see. We do use them in flash less aka iNVM only mode as
8086:157b.

>  In my case with your patch
> below as well as York's patch
> (https://patchwork.ozlabs.org/patch/400628/) I still see failures. The
> I210_SW_FW_SYNC reg returns swfw_sync=0x03, fwmask=0x20000, and
> swmask=0x2 which results in:
> 
> Driver can't access resource, SW_FW_SYNC timeout.
> Unable to acquire swfw sync
> Error Resetting the PHY
> e1000: e1000#0: ERROR: Hardware Initialization Failed

As follows my results:

unprogrammed i210
   01:00.0    - 8086:1531 - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
e1000: e1000#0: ERROR: Hardware Initialization Failed

programmed i210
   01:00.0    - 8086:157b - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
working

unprogrammed i211
   01:00.0    - 8086:1532 - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
working

programmed i211
   01:00.0    - 8086:1539 - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
working

> I've always had to ignore the return value from e1000_reset() to avoid
> this issue and use the devices.

As mentioned before for me only the unprogrammed i210 gives me grief as
it does not assert the CFG_DONE bit in the EEMNGCTL register upon PHY
reset. However the e1000_swfw_sync_acquire() always works just fine.

> Any ideas?

Maybe the flash less aka iNVM only i210 behaves differently.

Let me enquire Intel about this as well, I anyway need to ask our rep
about the latest eepromARM programming tool as we have an upcoming
production lot of a few thousand units arrive any minute now.

> I don't have any i211's but I'll see if I can get hold of an
> unprogrammed i210 to test with.

Sure, would be interesting to see whether yours behave equally.