[U-Boot] [PATCH 03/14] exynos4/4x12: cpu: add extra gpio base addresses

[Przemyslaw Marczak]

Hello Simon,

On 10/28/2014 02:10 AM, Simon Glass wrote:
> Hi Przemyslaw,
>
> On 24 October 2014 09:44, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
>> After remove the offsets in Exynos4/4x12 gpio enums, an addidional gpio base
>
> additional
>
ok :)
>> addresses are required.
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>> ---
>>   arch/arm/include/asm/arch-exynos/cpu.h | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/cpu.h b/arch/arm/include/asm/arch-exynos/cpu.h
>> index ba71714..78aceef 100644
>> --- a/arch/arm/include/asm/arch-exynos/cpu.h
>> +++ b/arch/arm/include/asm/arch-exynos/cpu.h
>> @@ -29,6 +29,8 @@
>>   #define EXYNOS4_MIU_BASE               0x10600000
>>   #define EXYNOS4_ACE_SFR_BASE           0x10830000
>>   #define EXYNOS4_GPIO_PART2_BASE                0x11000000
>> +#define EXYNOS4_GPIO_PART2_0           0x11000000 /* GPJ0 */
>> +#define EXYNOS4_GPIO_PART2_1           0x11000c00 /* GPX0 */
>>   #define EXYNOS4_GPIO_PART1_BASE                0x11400000
>>   #define EXYNOS4_FIMD_BASE              0x11C00000
>>   #define EXYNOS4_MIPI_DSIM_BASE         0x11C80000
>> @@ -70,7 +72,14 @@
>>   #define EXYNOS4X12_GPIO_PART4_BASE     0x106E0000
>>   #define EXYNOS4X12_ACE_SFR_BASE                0x10830000
>>   #define EXYNOS4X12_GPIO_PART2_BASE     0x11000000
>> +#define EXYNOS4X12_GPIO_PART2_0                0x11000000
>> +#define EXYNOS4X12_GPIO_PART2_1                0x11000040 /* GPK0 */
>> +#define EXYNOS4X12_GPIO_PART2_2                0x11000260 /* GPM0 */
>> +#define EXYNOS4X12_GPIO_PART2_3                0x11000c00 /* GPX0 */
>>   #define EXYNOS4X12_GPIO_PART1_BASE     0x11400000
>> +#define EXYNOS4X12_GPIO_PART1_0                0x11400000 /* GPA0 */
>> +#define EXYNOS4X12_GPIO_PART1_1                0x11400180 /* GPF0 */
>> +#define EXYNOS4X12_GPIO_PART1_2                0x11400240 /* GPJ0 */
>
> Why not just number them 0 to 7? It would be simpler.
>
> Also what are these actually used for now? Are they used in SPL perhaps?
>
> Regards,
> Simon
>
I introduced those sub parts because the main base addresses can be used 
by macro samsung_get_base..., so this not require to change each call in 
the code, and this is equal to the SOC documentation. Part is a 
documented base address. And the sub-part is only a hack for the gpio.

The non-dm gpio calls are used by the spl and of course very early by 
the pinmux, so we must be sure that the numbering is right.

This hack can be easy removed in the future, when dm be available earlier.

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com