[U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init

Igor Grinberg grinberg at compulab.co.il
Tue Oct 28 16:47:23 CET 2014


Hi Paul,

On 10/28/14 16:05, Paul Kocialkowski wrote:
> Signed-off-by: Paul Kocialkowski <contact at paulk.fr>

Usually, it is a good practice to add a commit message
(and not just the subject).

It will be highly appreciated if you can provide also an
explanation (in the commit message) of what and why it is done.

Thanks!

> ---
>  drivers/power/twl4030.c |    6 ++++++
>  include/twl4030.h       |    2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c
> index 3e50310..e578ae6 100644
> --- a/drivers/power/twl4030.c
> +++ b/drivers/power/twl4030.c
> @@ -98,4 +98,10 @@ void twl4030_power_mmc_init(void)
>  				TWL4030_PM_RECEIVER_VMMC1_VSEL_32,
>  				TWL4030_PM_RECEIVER_VMMC1_DEV_GRP,
>  				TWL4030_PM_RECEIVER_DEV_GRP_P1);
> +
> +	/* Set VMMC2 to 3.15 Volts */
> +	twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VMMC2_DEDICATED,
> +				TWL4030_PM_RECEIVER_VMMC2_VSEL_32,
> +				TWL4030_PM_RECEIVER_VMMC2_DEV_GRP,
> +				TWL4030_PM_RECEIVER_DEV_GRP_P1);
>  }
> diff --git a/include/twl4030.h b/include/twl4030.h
> index 093c61d..18795a6 100644
> --- a/include/twl4030.h
> +++ b/include/twl4030.h
> @@ -395,6 +395,8 @@
>  #define TWL4030_PM_RECEIVER_VDAC_VSEL_18		0x03
>  #define TWL4030_PM_RECEIVER_VMMC1_VSEL_30		0x02
>  #define TWL4030_PM_RECEIVER_VMMC1_VSEL_32		0x03
> +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_30		0x0B
> +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_32		0x0C
>  #define TWL4030_PM_RECEIVER_VSIM_VSEL_18		0x03
>  
>  /* Device Selection in PM Receiver Module */
> 

-- 
Regards,
Igor.


More information about the U-Boot mailing list