[U-Boot] [PATCH v1 00/10] arm, at91, spl: add spl support for the taurus and corvus boards

[Heiko Schocher]

Hello Andreas,

Am 25.10.2014 02:35, schrieb Andreas Bießmann:
> Hi Heiko,
>
> On 01.10.14 07:54, Heiko Schocher wrote:
>> This patchset add SPL support for the AT91SAM9G20 based taurus board, and
>> the AT91SAM9M10G45 based corvus board from siemens, and replaces the
>> at91bootstrap code.
>>
>> The boot.bin which replaces the at91bootstrap image can created with
>> mkimage:
>>
>> ./tools/mkimage -T atmelimage -d spl/u-boot-spl.bin spl/boot.bin
>>
>> For other SoC this step is done in one step ... should we add this
>> also for AT91 based boards?
>
> The sama5d3xek_* configs do this already. They automagically generate a
> boot.bin file. See arch/arm/cpu/armv7/at91/config.mk for reference.
> Maybe we can place it somewhere else to share between all atmel SoC
> (arm920, arm926, armv7)?

Hmm... I think about 2 places:

a) move "arch/arm/cpu/armv7/at91/config.mk" to "arch/arm/cpu/at91-common/config.mk"
b) scripts/Makefile.spl

I vote for b) as there are also entries for other SoCs ...

Could we solve this in a second step, so I can send a "v2" for
this series?

>> For example add a "u-boot.at91" target in the Makefile?
>>
>> This patchset is based on the common updates for the taurus
>> and corvus board:
>>
>> Patchwork [U-Boot] arm, at91: add generic board support for the taurus and corvus board
>> http://patchwork.ozlabs.org/patch/395398/
>>
>> Patchwork [U-Boot] arm, at91: add spi dataflash support for the taurus board
>> http://patchwork.ozlabs.org/patch/395400/
>
> This one has changes requested, is a v2 available?

Yes, not posted yet, as I waited for a review from you. I prepared
a "v2" (just running "MAKEALL arm") which contains all comments
except the above. I post it soon ... thanks for the review.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany