[U-Boot] [PATCH v2 3/3] video: speedup writing strings to fb console

[Stefano Babic]

Hi,

On 24/10/2014 16:33, Soeren Moch wrote:
> With enabled framebuffer console the printenv command can take several
> seconds to complete. This patch temporarily disables cache flush when
> writing strings to fb console. Then there is no noticable delay anymore.
> 
> Tested with imx6 hdmi framebuffer.
> 
> Signed-off-by: Soeren Moch <smoch at web.de>
> ---
> Cc: Stefano Babic <sbabic at denx.de>
> ---
>  drivers/video/cfb_console.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index 9231927..e7548e1 100644
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
> @@ -1160,10 +1160,19 @@ void video_putc(struct stdio_dev *dev, const char c)
>  
>  void video_puts(struct stdio_dev *dev, const char *s)
>  {
> +	int flush = cfb_do_flush_cache;
>  	int count = strlen(s);
>  
> +	/* temporarily disable cache flush */
> +	cfb_do_flush_cache = 0;
> +
>  	while (count--)
>  		video_putc(dev, *s++);
> +
> +	if (flush) {
> +		cfb_do_flush_cache = flush;
> +		flush_cache(VIDEO_FB_ADRS, VIDEO_SIZE);
> +	}
>  }

Sure it makes sense that the video is updated only once.

Acked-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================