[U-Boot] [PATCH] generic_board: do not set gd->fdt_blob unless CONFIG_OF_CONTROL=y

Masahiro YAMADA yamada.m at jp.panasonic.com
Sat Sep 6 19:09:27 CEST 2014


Hi Simon,


2014-09-07 1:33 GMT+09:00 Simon Glass <sjg at chromium.org>:
>>         /* Allow the early environment to override the fdt address */
>>         gd->fdt_blob = (void *)getenv_ulong("fdtcontroladdr", 16,
>>                                                 (uintptr_t)gd->fdt_blob);
>
> You effectively just remove this statement. Is it worth it for the
> extra #ifdefs?

IMHO, yes, I think meaningless code should not be compiled.


-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list