[U-Boot] [PATCH] generic_board: do not set gd->fdt_blob unless CONFIG_OF_CONTROL=y

Simon Glass sjg at chromium.org
Mon Sep 8 20:41:56 CEST 2014


Hi Masahiro,

On 6 September 2014 11:09, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> Hi Simon,
>
>
> 2014-09-07 1:33 GMT+09:00 Simon Glass <sjg at chromium.org>:
>>>         /* Allow the early environment to override the fdt address */
>>>         gd->fdt_blob = (void *)getenv_ulong("fdtcontroladdr", 16,
>>>                                                 (uintptr_t)gd->fdt_blob);
>>
>> You effectively just remove this statement. Is it worth it for the
>> extra #ifdefs?
>
> IMHO, yes, I think meaningless code should not be compiled.

OK. While I don't like the extra #ifdefs for small benefit, I agree
there is not much sense in providing this FDT unless U-Boot is
actually using it.

Acked-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list