[U-Boot] [PATCH 3/3] arm: mx35: use common timer functions

Stefano Babic sbabic at denx.de
Tue Sep 16 12:56:13 CEST 2014


Hi Andrew,


On 12/08/2014 16:26, andrew.ruder at elecsyscorp.com wrote:
> From: Andrew Ruder <andrew.ruder at elecsyscorp.com>
> 
> This patch moves mx35 to the common timer functions added in commit
> 
>   8dfafdd - Introduce common timer functions <Rob Herring>
> 
> The (removed) mx35 timer code (specifically __udelay()) could deadlock at
> the 32-bit boundary of get_ticks().  get_ticks() returned a 32-bit value
> cast up to a 64-bit value.  If get_ticks() + tmo in __udelay() crossed
> the 32-bit boundary, the while condition became unconditionally true and
> locks the processor.  Rather than patch the specific mx35 issues, simply
> move everything over to the common code.
> 
> Signed-off-by: Andrew Ruder <andrew.ruder at elecsyscorp.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
> 
> This patch has been COMPILE tested only.  The situation isn't quite as
> bad on mx35 as 32-bit rollover occurs in about a day and a half.
> 

I have applied both patches for MX31 and MX35, even if I had no time to
make myself a test. I hope in this way there is more testers before release.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list