[U-Boot] [PATCH] ARM: mx6: Add support for Kosagi Novena

[Stefano Babic]

On 30/08/2014 16:20, Marek Vasut wrote:
> On Saturday, August 30, 2014 at 03:55:48 PM, Fabio Estevam wrote:
>> On Sat, Aug 30, 2014 at 9:40 AM, Marek Vasut <marex at denx.de> wrote:
>>> On Friday, August 29, 2014 at 07:08:54 PM, Fabio Estevam wrote:
>>> [...]
>>>
>>>>> +/* Extra U-Boot environment. */
>>>>> +#define CONFIG_EXTRA_ENV_SETTINGS                                    
>>>>>  \ +       "fdt_high=0xffffffff\0"                                   
>>>>>      \ +       "initrd_high=0xffffffff\0"                            
>>>>>          \ +       "consdev=ttymxc1\0"                               
>>>>>              \ +       "baudrate=115200\0"                           
>>>>>                  \ +       "bootdev=/dev/mmcblk0p1\0"                
>>>>>                      \ +       "rootdev=/dev/mmcblk0p2\0"            
>>>>>                          \ +       "netdev=eth0\0"                   
>>>>>                              \ +      
>>>>> "rootpath=/opt/eldk-5.5/armv7a-hf/rootfs-qte-sdk\0"             \
>>>>
>>>> This seems to be a too specific rootpath name. Not everyone will use
>>>> this same rootpath.
>>>
>>> You're right, but what kind of sane default do you suggest ? The user
>>> will overwrite this anyway ...
>>
>> I would say just get rid of this default rootpath entry.
>>
>> Users will have to add their own ipaddr, serverip and rootpath anyway.
> 
> Sure, but having some default value is better than having all the scripts broken 
> because the variable is not set at all, right ?

No, I do not think so. If it is broken, a user must check for it and set
it to an appropriate name. The path is even wrong if another ELDK
version is used. I would suggest, as Fabio did, to drop it.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================