[U-Boot] [PATCH 3/7] ARM: sun6i: Add support for the new power control module found on the A31

[Ian Campbell]

On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote:
> From: Oliver Schinagl <oliver at schinagl.nl>
> 
> To setup clocks and control voltages.

perhaps add "... For P2WI and PIO", since that is apparently what it is
doing?

> HdG: Rename the files from the somewhat generic pmu name to prcm.{c,h}
> HdG: Make the prcm code only deal with the prcm, remove axp221 bits

I suppose these comments aren't really meaningful in the final commit
message, probably better to drop them.

> + * Based on sun6i sources and earlier U-Boot Allwiner A10 SPL work

Typo in "Allwiner"

> +	reg_val = readl(&prcm->apb0_gate);
> +	reg_val |= PRCM_APB0_GATE_P2WI | PRCM_APB0_GATE_PIO;
> +	writel(reg_val, &prcm->apb0_gate);
> +
> +	reg_val = readl(&prcm->apb0_reset);
> +	reg_val |= PRCM_APB0_RESET_P2WI | PRCM_APB0_RESET_PIO;
> +	writel(reg_val, &prcm->apb0_reset);

I think these should both use the setbits helper.

Ian.