[U-Boot] [PATCH] PATI: fix broken SPI access

[Tom Rini]

On Tue, Sep 30, 2014 at 08:06:43PM +0530, Jagan Teki wrote:
> On 30 September 2014 18:41, David Müller (ELSOFT AG)
> <d.mueller at elsoft.ch> wrote:
> > Jagan Teki wrote:
> >> On 30 September 2014 16:53, David Müller <d.mueller at elsoft.ch> wrote:
> >>> +int board_early_init_f(void)
> >>> +{
> >>> +       spi_init_f();
> >>
> >> Why you need to do this, spi_init_f is trying to call from
> >> arch/powerpc/lib/board.c
> >> any specific reason, I couldn't understand the fix you mentioned on
> >> the commit body.
> >
> > There is an EEPROM attached to the SPI channel containing vital board
> > data. Calling spi_init_f() from arch/powerpc/lib/board.c will be too late.
> 
> Sorry, this looks an other issue - but anyway we're trying to remove
> spi_init* stuff
> from drivers/spi/* in future and I don't think it's a good idea to use that.

It's also not a good idea to say that we'll leave a board broken until
something better comes along.  There should be a comment added to the
code here making it clear _why_ we need this done early.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140930/28549947/attachment.pgp>