[U-Boot] [PATCH] PATI: fix broken SPI access

David Müller (ELSOFT AG) d.mueller at elsoft.ch
Tue Sep 30 16:58:35 CEST 2014


Jagan Teki wrote:
> On 30 September 2014 18:41, David Müller (ELSOFT AG)
> <d.mueller at elsoft.ch> wrote:
>> Jagan Teki wrote:
>>> On 30 September 2014 16:53, David Müller <d.mueller at elsoft.ch> wrote:
>>>> +int board_early_init_f(void)
>>>> +{
>>>> +       spi_init_f();
>>>
>>> Why you need to do this, spi_init_f is trying to call from
>>> arch/powerpc/lib/board.c
>>> any specific reason, I couldn't understand the fix you mentioned on
>>> the commit body.
>>
>> There is an EEPROM attached to the SPI channel containing vital board
>> data. Calling spi_init_f() from arch/powerpc/lib/board.c will be too late.
> 
> Sorry, this looks an other issue - but anyway we're trying to remove

What kind of "other issue" do you mean?

> spi_init* stuff
> from drivers/spi/* in future and I don't think it's a good idea to use that.

In this case what is the proposed way of initializing the SPI subsystem?



More information about the U-Boot mailing list