[U-Boot] [PATCH] usb: Remove unused variable in usb_setup_descriptor()

Hans de Goede hdegoede at redhat.com
Mon Apr 20 09:27:51 CEST 2015


Hi,

On 19-04-15 15:36, Simon Glass wrote:
> Hi Hans,
>
> On 19 April 2015 at 03:33, Hans de Goede <hdegoede at redhat.com> wrote:
>> The compiler did not catch this as it was marked __maybe_unused.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>   common/usb.c | 2 --
>>   1 file changed, 2 deletions(-)
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> Thanks for spotting this. Another minor problem is that
> get_descriptor_len() allocates a 512-byte buffer but only 64 bytes is
> needed.

Good one, someone should probably write a patch for this. Consider such
a patch Acked-by: Hans de Goede <hdegoede at redhat.com> .

Whom is going to pick up these fixes and upstream them ?

Regards,

Hans


More information about the U-Boot mailing list