[U-Boot] [PATCH] usb: Remove unused variable in usb_setup_descriptor()

Marek Vasut marex at denx.de
Tue Apr 21 12:21:35 CEST 2015


On Monday, April 20, 2015 at 09:27:51 AM, Hans de Goede wrote:
> Hi,
> 
> On 19-04-15 15:36, Simon Glass wrote:
> > Hi Hans,
> > 
> > On 19 April 2015 at 03:33, Hans de Goede <hdegoede at redhat.com> wrote:
> >> The compiler did not catch this as it was marked __maybe_unused.
> >> 
> >> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> >> ---
> >> 
> >>   common/usb.c | 2 --
> >>   1 file changed, 2 deletions(-)
> > 
> > Acked-by: Simon Glass <sjg at chromium.org>
> > 
> > Thanks for spotting this. Another minor problem is that
> > get_descriptor_len() allocates a 512-byte buffer but only 64 bytes is
> > needed.
> 
> Good one, someone should probably write a patch for this. Consider such
> a patch Acked-by: Hans de Goede <hdegoede at redhat.com> .
> 
> Whom is going to pick up these fixes and upstream them ?

Applied to u-boot-usb/master, thanks!

Best regards,
Marek Vasut


More information about the U-Boot mailing list