[U-Boot] [PATCH] x86: minnowmax: use the correct NOR in the configuration

Bin Meng bmeng.cn at gmail.com
Sat Apr 25 00:42:46 CEST 2015


Hi Gabriel,

On Fri, Apr 24, 2015 at 10:42 PM, Gabriel Huau <contact at huau-gabriel.fr> wrote:
> Hi Bin,
>
>
> On 04/23/2015 08:20 PM, Bin Meng wrote:
>>
>> Hi Gabriel,
>>
>> On Fri, Apr 24, 2015 at 12:16 AM, Gabriel Huau <contact at huau-gabriel.fr>
>> wrote:
>>>
>>> The SPI NOR on the minnowboard max is a MICRON N25Q064A
>>>
>>> Signed-off-by: Gabriel Huau <contact at huau-gabriel.fr>
>>> ---
>>>   include/configs/minnowmax.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/configs/minnowmax.h b/include/configs/minnowmax.h
>>> index 3c7b266..72393fa 100644
>>> --- a/include/configs/minnowmax.h
>>> +++ b/include/configs/minnowmax.h
>>> @@ -43,7 +43,7 @@
>>>
>>>   #define CONFIG_SCSI_DEV_LIST            \
>>>          {PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA}
>>> -#define CONFIG_SPI_FLASH_SST
>>> +#define CONFIG_SPI_FLASH_STMICRO
>>>
>>>   #define CONFIG_MMC
>>>   #define CONFIG_SDHCI
>>> --
>>
>> I think you need also update minnowmax.dts file to change the compatible
>> string.
>>
>> Regards,
>> Bin
>
>
> Well ... I didn't see that as the NOR was still working on the board, I
> didn't find any reference except in the device tree for this compatible
> string, do you know if this is really used or not?

The spi flash compatible string is not used by the spi flash driver.

> I'll do the modification anyway, it's always better to put the correct
> information.
>

Yep, it is a hint for someone else to figure out what spi flash is
mounted on the board.

Regards,
Bin


More information about the U-Boot mailing list