[U-Boot] [PATCH v2 02/19] video: Work around lack of pinctrl
Simon Glass
sjg at chromium.org
Mon Aug 3 16:19:20 CEST 2015
We haven't quite got pinctrl ready to apply to mainline. We don't want to
GPIO pull-up/down support to the driver model GPIO layer either. So work
around this for now.
We can address this when pinctrl is complete.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
Changes in v2:
- Add a new patch to hold off the need for driver model pinctrl
drivers/video/bridge/video-bridge-uclass.c | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/video/bridge/video-bridge-uclass.c b/drivers/video/bridge/video-bridge-uclass.c
index e1ea428..6c5990f 100644
--- a/drivers/video/bridge/video-bridge-uclass.c
+++ b/drivers/video/bridge/video-bridge-uclass.c
@@ -57,22 +57,30 @@ static int video_bridge_pre_probe(struct udevice *dev)
debug("%s: Could not decode sleep-gpios (%d)\n", __func__, ret);
return ret;
}
- ret = dm_gpio_set_pull(&uc_priv->sleep, GPIO_PULL_NONE);
- if (ret) {
- debug("%s: Could not set sleep pull value\n", __func__);
- return ret;
- }
+ /*
+ * Drop this for now as we do not have driver model pinctrl support
+ *
+ * ret = dm_gpio_set_pull(&uc_priv->sleep, GPIO_PULL_NONE);
+ * if (ret) {
+ * debug("%s: Could not set sleep pull value\n", __func__);
+ * return ret;
+ * }
+ */
ret = gpio_request_by_name(dev, "reset-gpios", 0, &uc_priv->reset,
GPIOD_IS_OUT);
if (ret) {
debug("%s: Could not decode reset-gpios (%d)\n", __func__, ret);
return ret;
}
- ret = dm_gpio_set_pull(&uc_priv->reset, GPIO_PULL_NONE);
- if (ret) {
- debug("%s: Could not set reset pull value\n", __func__);
- return ret;
- }
+ /*
+ * Drop this for now as we do not have driver model pinctrl support
+ *
+ * ret = dm_gpio_set_pull(&uc_priv->reset, GPIO_PULL_NONE);
+ * if (ret) {
+ * debug("%s: Could not set reset pull value\n", __func__);
+ * return ret;
+ * }
+ */
ret = gpio_request_by_name(dev, "hotplug-gpios", 0, &uc_priv->hotplug,
GPIOD_IS_IN);
if (ret && ret != -ENOENT) {
--
2.5.0.rc2.392.g76e840b
More information about the U-Boot
mailing list