[U-Boot] [PATCH 1/2] configs: ti_armv7_keystone2: fix initrd address at args_ramfs

Tom Rini trini at konsulko.com
Tue Aug 4 18:16:22 CEST 2015


On Tue, Aug 04, 2015 at 11:45:17AM -0400, Vitaly Andrianov wrote:
> 
> 
> On 08/04/2015 11:23 AM, Tom Rini wrote:
> >On Tue, Aug 04, 2015 at 11:16:15AM -0400, Vitaly Andrianov wrote:
> >
> >>This patch set the correct initrd address to much rdaddr, which used at
> >>get_fs_ramfs commad.
> >>
> >>Fixes: 3e97f0b63c8e ("configs: ti_armv7_keystone2: switch addresses
> >>to generic addresses")
> >>
> >>Signed-off-by: Vitaly Andrianov <vitalya at ti.com>
> >>---
> >>  include/configs/ti_armv7_keystone2.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
> >>index 7b67620..454f1df 100644
> >>--- a/include/configs/ti_armv7_keystone2.h
> >>+++ b/include/configs/ti_armv7_keystone2.h
> >>@@ -253,7 +253,7 @@
> >>  	"init_ramfs=run args_all args_ramfs get_fs_ramfs\0"		\
> >>  	"args_ramfs=setenv bootargs ${bootargs} "			\
> >>  		"rdinit=/sbin/init rw root=/dev/ram0 "			\
> >>-		"initrd=0x802000000,9M\0"				\
> >>+		"initrd=0x808080000,9M\0"				\
> >
> >There's two related problems here.  Making initrd match ${rdaddr} would
> >be best done by doing "initrd=${rdaddr}" here, same as whacking in the
> 
> For keystone devices we load filesystem at ${rdaddr}, but need to pass
> to the kernel initrd=<${rdaddr} + 0x780000000)>, which is LPAE address.

Why do you need to do that?  Shouldn't the kernel be able to move things
around as needed?  But if we must then please do some expr to do that
addition so that if people change rdaddr they don't get unexpected
breakage.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150804/05057b58/attachment.sig>


More information about the U-Boot mailing list