[U-Boot] [PATCH v2 3/3] x86: Show the un-relocated IP address in exceptions

Bin Meng bmeng.cn at gmail.com
Thu Aug 6 06:35:00 CEST 2015


Hi Simon,

On Mon, Aug 3, 2015 at 8:15 AM, Simon Glass <sjg at chromium.org> wrote:
> When trying to figure out where an exception has occured, the relocated
> address is not a lot of help. Its value depends on various factors. Show
> the un-relocated IP as well. This can be looked up in System.map directly.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v2:
> - Tweak the dump_regs() output to say 'Original EIP'
>
>  arch/x86/cpu/interrupts.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/cpu/interrupts.c b/arch/x86/cpu/interrupts.c
> index 3a9c2d4..4c79cb3 100644
> --- a/arch/x86/cpu/interrupts.c
> +++ b/arch/x86/cpu/interrupts.c
> @@ -103,6 +103,8 @@ static void dump_regs(struct irq_regs *regs)
>
>         printf("EIP: %04x:[<%08lx>] EFLAGS: %08lx\n",
>                         (u16)cs, eip, eflags);
> +       if (gd->flags & GD_FLG_RELOC)
> +               printf("Original EIP :[<%08lx>]\n", regs->eip - gd->reloc_off);

This should not be 'regs->eip'. It should be just 'eip'.

>
>         printf("EAX: %08lx EBX: %08lx ECX: %08lx EDX: %08lx\n",
>                 regs->eax, regs->ebx, regs->ecx, regs->edx);
> --

Regards,
Bin


More information about the U-Boot mailing list