[U-Boot] [PATCH] dm: serial: Add a REQUIRE_SERIAL_CONSOLE option for boards with no serial port

Simon Glass sjg at chromium.org
Thu Aug 6 18:10:25 CEST 2015


hi Hans,

On 1 August 2015 at 10:05, Simon Glass <sjg at chromium.org> wrote:
> Hi Hans,
>
> On 25 July 2015 at 03:58, Hans de Goede <hdegoede at redhat.com> wrote:
>> Currently the serial code assumes that there is always at least one serial
>> port (and panics / crashes due to null pointer dereferences when there is
>> none).
>>
>> This makes it impossible to use u-boot on boards where there is no (debug)
>> serial port, because e.g. all uart pins are muxed to another function.
>>
>> This commit adds a CONFIG_REQUIRE_SERIAL_CONSOLE Kconfig option, which
>> defaults to y (preserving existing behavior), which can be set to n on
>> such boards to make them work.
>>
>> This commit only implements this for CONFIG_DM_SERIAL=y configs, as allowing
>> running without a serial port for CONFIG_DM_SERIAL=n configs is non trivial,
>> and is not necessary at this moment.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>  drivers/serial/Kconfig         | 11 +++++++++++
>>  drivers/serial/serial-uclass.c | 20 +++++++++++++++++---
>>  2 files changed, 28 insertions(+), 3 deletions(-)
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> A few nits below.

Are you OK with me fixing the nits when I apply it or would you like to resent?

Regards,
Simon


More information about the U-Boot mailing list