[U-Boot] [PATCH v5 5/5] usb: lpc32xx: add host USB driver

[LEMIEUX, SYLVAIN]

Hi Vladimir,

See comment below.

> -----Original Message-----
> From: Vladimir Zapolskiy [mailto:vz at mleia.com]
>
> Hi Sylvain,
>
> On 05.08.2015 21:31, slemieux.tyco at gmail.com wrote:
> > From: Sylvain Lemieux <slemieux at tycoint.com>
> >
> > Incorporate USB driver from legacy LPCLinux NXP BSP.
> > The files taken from the legacy patch are:
> > - lpc32xx USB driver
> > - lpc3250 header file USB registers definition.
> >
> > The legacy driver was updated and clean-up as part of the integration with the latest u-boot.
> >
> > Signed-off-by: Sylvain Lemieux <slemieux at tycoint.com>
> > ---

[...]

> >
> > diff --git a/arch/arm/cpu/arm926ejs/lpc32xx/devices.c b/arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> > index 0d2ef7a..3da0952 100644
> > --- a/arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> > +++ b/arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> > @@ -82,6 +82,12 @@ void lpc32xx_i2c_init(unsigned int devnum)
> >     writel(ctrl, &clk->i2cclk_ctrl);
> >  }
> >
> > +void lpc32xx_usb_init(void)
> > +{
> > +   /* Do not route the UART 5 Tx/Rx pins to the USB D+ and USB D- pins. */
> > +   clrbits_le32(&ctrl->ctrl, UART_CTRL_UART5_USB_MODE);
> > +}
>
> Please replace clrbits_le32() with writel(), the same motivation as
> shown for DMA driver.

It is not possible to do it for this instance; the control register is affecting multiple UARTs;
refer to UM10326 LPC32x0 User manual Rev. 3, table 459 for details.

[...]

> --
> With best wishes,
> Vladimir

________________________________

This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.