[U-Boot] [PATCH] imx: mx6 move TARGET_xx Kconfig option to mx6 specific Kconfig file

[Peng Fan]

On Thu, Aug 06, 2015 at 11:34:16AM +0200, Soeren Moch wrote:
>On 08/06/15 07:43, Peng Fan wrote:
>>Move TARGET_xx Kconfig option based on mx6 to arch/arm/cpu/armv7/mx6/Kconfig.
>>Add enable "CONFIG_ARCH_MX6" for boards based on mx6.
>>Then we can choose target boards using "make ARCH=arm menuconfig"
>>with ARCH_MX6 defined.
>>
>>If using original way, we have no chance to enable ARCH_MX6 when
>>"make menuconfig". Even define CONFIG_ARCH_MX6=y in xx_defconfig,
>>kconfig will complains "arch/../configs/platinum_titanium_defconfig:3:
>>warning: override: TARGET_PLATINUM_TITANIUM changes choice state"
>>
>>Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
>>Cc: Stefano Babic <sbabic at denx.de>
>>Cc: Heiko Schocher <hs at denx.de>
>>Cc: Tim Harvey <tharvey at gateworks.com>
>>Cc: Eric Bénard <eric at eukrea.com>
>>Cc: Fabio Estevam <fabio.estevam at freescale.com>
>>Cc: Eric Nelson <eric.nelson at boundarydevices.com>
>>Cc: Marek Vasut <marex at denx.de>
>>Cc: Christian Gmeiner <christian.gmeiner at gmail.com>
>>Cc: Stefan Roese <sr at denx.de>
>>Cc: Soeren Moch <smoch at web.de>
>>Cc: Otavio Salvador <otavio at ossystems.com.br>
>>Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
>>---
>[...]
>>index dce7ffc..b7481e7 100644
>>--- a/arch/arm/cpu/armv7/mx6/Kconfig
>>+++ b/arch/arm/cpu/armv7/mx6/Kconfig
>>@@ -46,6 +46,113 @@ config TARGET_SECOMX6
>>  config TARGET_TQMA6
>>  	bool "TQ Systems TQMa6 board"
>>
>>+config TARGET_UDOO
>>+	bool "Support udoo"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_OT1200
>>+	bool "Bachmann OT1200"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_WANDBOARD
>>+	bool "Support wandboard"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_WARP
>>+	bool "Support WaRP"
>>+	select CPU_V7
>>+
>>+config TARGET_MX6CUBOXI
>>+	bool "Support Solid-run mx6 boards"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_MX6SLEVK
>>+	bool "Support mx6slevk"
>>+	select CPU_V7
>>+
>>+config TARGET_MX6SXSABRESD
>>+	bool "Support mx6sxsabresd"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+	select DM
>>+	select DM_THERMAL
>>+
>>+config TARGET_MX6UL_14X14_EVK
>>+	bool "Support mx6ul_14x14_evk"
>>+	select CPU_V7
>>+	select DM
>>+	select DM_THERMAL
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_MX6QARM2
>>+	bool "Support mx6qarm2"
>>+	select CPU_V7
>>+
>>+config TARGET_MX6QSABREAUTO
>>+	bool "Support mx6qsabreauto"
>>+	select CPU_V7
>>+	select DM
>>+	select DM_THERMAL
>>+
>>+config TARGET_MX6SABRESD
>>+	bool "Support mx6sabresd"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+	select DM
>>+	select DM_THERMAL
>>+
>>+config TARGET_GW_VENTANA
>>+	bool "Support gw_ventana"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_TITANIUM
>>+	bool "Support titanium"
>>+	select CPU_V7
>>+
>>+config TARGET_NITROGEN6X
>>+	bool "Support nitrogen6x"
>>+	select CPU_V7
>>+
>>+config TARGET_CGTQMX6EVAL
>>+	bool "Support cgtqmx6eval"
>>+	select CPU_V7
>>+
>>+config TARGET_EMBESTMX6BOARDS
>>+	bool "Support embestmx6boards"
>>+	select CPU_V7
>>+
>>+config TARGET_ARISTAINETOS
>>+	bool "Support aristainetos"
>>+	select CPU_V7
>>+
>>+config TARGET_ARISTAINETOS2
>>+	bool "Support aristainetos2"
>>+	select CPU_V7
>>+
>>+config TARGET_KOSAGI_NOVENA
>>+	bool "Support Kosagi Novena"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_TBS2910
>>+	bool "Support tbs2910"
>>+	select CPU_V7
>>+
>>+config TARGET_PLATINUM_PICON
>>+	bool "Support platinum-picon"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>+config TARGET_PLATINUM_TITANIUM
>>+	bool "Support platinum-titanium"
>>+	select CPU_V7
>>+	select SUPPORT_SPL
>>+
>>  endchoice
>>
>>  config SYS_SOC
>>@@ -53,5 +160,26 @@ config SYS_SOC
>>
>>  source "board/seco/Kconfig"
>>  source "board/tqc/tqma6/Kconfig"
>>+source "board/udoo/Kconfig"
>>+source "board/bachmann/ot1200/Kconfig"
>>+source "board/wandboard/Kconfig"
>>+source "board/warp/Kconfig"
>>+source "board/compulab/cm_fx6/Kconfig"
>>+source "board/solidrun/mx6cuboxi/Kconfig"
>>+source "board/freescale/mx6qarm2/Kconfig"
>>+source "board/freescale/mx6qsabreauto/Kconfig"
>>+source "board/freescale/mx6sabresd/Kconfig"
>>+source "board/freescale/mx6slevk/Kconfig"
>>+source "board/freescale/mx6sxsabresd/Kconfig"
>>+source "board/freescale/mx6ul_14x14_evk/Kconfig"
>>+source "board/gateworks/gw_ventana/Kconfig"
>>+source "board/barco/platinum/Kconfig"
>>+source "board/barco/titanium/Kconfig"
>>+source "board/boundary/nitrogen6x/Kconfig"
>>+source "board/congatec/cgtqmx6eval/Kconfig"
>>+source "board/embest/mx6boards/Kconfig"
>>+source "board/aristainetos/Kconfig"
>>+source "board/kosagi/novena/Kconfig"
>>+source "board/tbs/tbs2910/Kconfig"
>>
>>  endif
>[...]
>
>
>I would suggest to sort the config options and include files alphabetically.

I can sort them in order and send out v2 later.

>Also I think we don't need "Support" in the board select options, unfortunately this
>is already not consistent in arch/arm/cpu/armv7/mx6/Kconfig .

Would you please more clear about this? I can not follow you.
The reason I did this patch is that we can not select ARCH_MX6,
if all the board target options in arch/arm/Kconfig. Since we can not select
ARCH_MX6, the Kconfig options in arch/arm/cpu/armv7/mx6/Kconfig will not effect.

Regards,
Peng.

>
>Besides that:
>Acked-by: Soeren Moch <smoch at web.de>
>
>Regards,
>Soeren
>

--