[U-Boot] [PATCH v2 5/6] Tidy up some defconfig files

[Simon Glass]

Hi Tom,

On 11 August 2015 at 09:48, Tom Warren <TWarren at nvidia.com> wrote:
> Simon,
>
>> -----Original Message-----
>> From: Simon Glass [mailto:sjg at google.com] On Behalf Of Simon Glass
>> Sent: Tuesday, August 11, 2015 6:39 AM
>> To: U-Boot Mailing List
>> Cc: Bin Meng; Joe Hershberger; Simon Glass; Akshay Saraswat; Vikas Manocha;
>> VishnuPatekar; Stefano Babic; Marek Vasut; Siarhei Siamashka; Nikita Kiryanov;
>> Michal Simek; Chander Kashyap; Tom Warren; Chin-Liang See; Hans de Goede;
>> Priyanka Jain; Pavel Machek; Codrin Ciubotariu; Michal Suchanek; Nitin Garg;
>> Markus Niebel; Stephen Warren; Paul Kocialkowski; Przemyslaw Marczak;
>> Lokesh Vutla; Aneesh Bansal; Tom Rini; Peng Fan; Allen Martin; Stefan Roese;
>> Jens Lucius; Dinh Nguyen; Masahiro Yamada; York Sun; Otavio Salvador; Alison
>> Wang; Chen-Yu Tsai; Wang Dongsheng
>> Subject: [PATCH v2 5/6] Tidy up some defconfig files
>>
>> Several files are out of order. This means that when the moveconfig tool
>> moves CONFIG options to Kconfig it generates a large diff. To avoid this,
>> reorder the files first.
> It appears (for P2571, at least) that you are not only reordering options (you moved CONFIG_TEGRA114_SPI), but removing some (CONFIG_SPL_DM and CONFIG_USE_PRIVATE_LIBGCC).
> If that's the intention, and removing those two options (because they're declared somewhere else?) doesn't affect the build/functionality, then perhaps two different patches are warranted - a cleanup patch (remove unused/unneeded config options) and then a reorder patch?
>

That looks wrong to me. I think it is because I did not have a correct
toolchain for moveconfig for aarch64. I will take a look.

> Tom
> --
> nvpublic


Thanks,
Simon