[U-Boot] [PATCH v2 6/6] net: Move CONFIG_E1000 options to Kconfig

Joe Hershberger joe.hershberger at gmail.com
Tue Aug 11 19:34:08 CEST 2015


Hi Simon,

On Tue, Aug 11, 2015 at 12:19 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Joe,
>
> On 11 August 2015 at 09:53, Joe Hershberger <joe.hershberger at gmail.com> wrote:
>> Hi Simon,
>>
>> On Tue, Aug 11, 2015 at 8:39 AM, Simon Glass <sjg at chromium.org> wrote:
>>> Move config for the E1000 Ethernet driver to Kconfig and tidy up affected
>>> boards.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>
>>> Changes in v2:
>>> - Add CONFIG_NETDEVICES where needed
>>
>> I'm surprised to see this.  In drivers/net/Kconfig we say "default y
>> if DM_ETH for NETDEVICES". That must mean that you are not enabling
>> DM_ETH, but that seems wrong.
>
> This series adds driver model support for e1000 but does not require
> it. Most boards don't use driver model for e1000, and that switch-over
> is a separate issue.

OK, that makes sense.

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list