[U-Boot] [PATCH v3 3/3] x86: Show the un-relocated IP address in exceptions

Simon Glass sjg at chromium.org
Wed Aug 12 05:55:39 CEST 2015


On 10 August 2015 at 23:49, Bin Meng <bmeng.cn at gmail.com> wrote:
> On Tue, Aug 11, 2015 at 12:02 PM, Simon Glass <sjg at chromium.org> wrote:
>> When trying to figure out where an exception has occured, the relocated
>> address is not a lot of help. Its value depends on various factors. Show
>> the un-relocated IP as well. This can be looked up in System.map directly.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> Reviewed-by: Tom Rini <trini at konsulko.com>
>> ---
>>
>> Changes in v3:
>> - Replace 'regs->eip' with 'eip'
>>
>> Changes in v2:
>> - Tweak the dump_regs() output to say 'Original EIP'
>>
>>  arch/x86/cpu/interrupts.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/cpu/interrupts.c b/arch/x86/cpu/interrupts.c
>> index 9217307..addd26e 100644
>> --- a/arch/x86/cpu/interrupts.c
>> +++ b/arch/x86/cpu/interrupts.c
>> @@ -103,6 +103,8 @@ static void dump_regs(struct irq_regs *regs)
>>
>>         printf("EIP: %04x:[<%08lx>] EFLAGS: %08lx\n",
>>                         (u16)cs, eip, eflags);
>> +       if (gd->flags & GD_FLG_RELOC)
>> +               printf("Original EIP :[<%08lx>]\n", eip - gd->reloc_off);
>>
>>         printf("EAX: %08lx EBX: %08lx ECX: %08lx EDX: %08lx\n",
>>                 regs->eax, regs->ebx, regs->ecx, regs->edx);
>> --
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Applied to u-boot-x86.


More information about the U-Boot mailing list