[U-Boot] [RESEND PATCH] usb: gadget: f_thor: Allocate request up to THOR_PACKET_SIZE

[Lukasz Majewski]

Hi Michal,

> Hi Lukasz,
> 
> On 04/24/2015 05:46 PM, Lukasz Majewski wrote:
> > Hi Michal,
> > 
> >> From: Siva Durga Prasad Paladugu <siva.durga.paladugu at xilinx.com>
> >>
> >> Allocate request up to THOR_PACKET_SIZE not the ep0->maxpacket
> >> as the descriptors data depend on the number of descriptors
> >> and this 64 bytes were not enough and the buffer might overflow
> >> which results in memalign failures later.
> >>
> >> Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> >> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> >> ---
> >>
> >>  drivers/usb/gadget/f_thor.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/gadget/f_thor.c
> >> b/drivers/usb/gadget/f_thor.c index 31eec36be876..5c8f6768519c
> >> 100644 --- a/drivers/usb/gadget/f_thor.c
> >> +++ b/drivers/usb/gadget/f_thor.c
> >> @@ -775,7 +775,7 @@ static int thor_func_bind(struct
> >> usb_configuration *c, struct usb_function *f) goto fail;
> >>  	}
> >>  	dev->req->buf = memalign(CONFIG_SYS_CACHELINE_SIZE,
> >> -				 gadget->ep0->maxpacket);
> >> +				 THOR_PACKET_SIZE);
> >>  	if (!dev->req->buf) {
> >>  		status = -ENOMEM;
> >>  		goto fail;
> > 
> > Applied to u-boot-dfu. Thanks!
> > 
> 
> I can't see this patch in your branch. Did you add it?

Please look into u-boot-dfu/testing branch.

I've placed them there for testing. Afterwards I will put them to
master branch

> 
> Thanks,
> Michal
> 



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group