[U-Boot] [PATCH] Add clarifications to the x86 README

Bin Meng bmeng.cn at gmail.com
Wed Aug 12 15:59:15 CEST 2015


Hi Igor,

On Wed, Aug 12, 2015 at 9:40 PM, Stoppa, Igor <igor.stoppa at intel.com> wrote:
> Hi Bin,
>
> On 12 August 2015 at 16:27, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Igor,
>>
>> On Wed, Aug 12, 2015 at 8:20 PM, Igor Stoppa <igor.stoppa at intel.com> wrote:
>>> Explicitly list the targets supported in each section of the instructions
>>> from the x86 README.
>>>
>>
>> Nits: we should put tags in the patch/commit title, eg:
>>
>> x86: Add clarifications to the x86 README
>
> ok, will fix it
>
> [...]
>
>>> -Intel Crown Bay specific instructions:
>>> +Intel Crown Bay specific instructions (raw mode):
>>
>> I think we don't need add (raw mode) as you already added a section
>> header above.
>
> This was intentional. You are absolutely right that it's redundant,
> but I was trying to make the doc more friendly toward someone (like
> yours truly :-) who approaches it for the first time.
> Reading it, sometimes I had the feeling I wasn't 100% sure of what a
> certain section was referring to.

I am OK, Simon?

>
> Some sections are not exactly short.
>
> But if you still think it should be removed, I'll do so.
>

Regards,
Bin


More information about the U-Boot mailing list