[U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

[York Sun]

+Codrin

Somehow I dropped Codrin in last reply.

On 08/10/2015 01:45 PM, York Sun wrote:
> 
> 
> On 08/10/2015 01:05 PM, Joe Hershberger wrote:
>> Hi York,
>>
>> On Mon, Aug 10, 2015 at 3:03 PM, York Sun <yorksun at freescale.com> wrote:
>>>
>>>
>>> On 08/10/2015 12:57 PM, Joe Hershberger wrote:
>>>> Too much top-posting.
>>>>
>>>> On Mon, Aug 10, 2015 at 2:41 PM, York Sun <yorksun at freescale.com> wrote:
>>>>> SPL doesn't use net/eth.c. You add a call in env_flags.c.
>>>>>
>>>>> I think you can put it in header file and use static inline, or keep it in the
>>>>> same file where it is called.
>>>>
>>>> That is probably fine.
>>>>
>>>>> Another way is to undef CONFIG_CMD_NET for SPL part. It is default to 'y' in
>>>>> Kconfig. Joe may have some good suggestion.
>>>>
>>>> I don't think this is the reason. The problem is that net is *not*
>>>> build for SPL, but env is.
>>>
>>> Yes, env is built. The offending lines in common/env_flags.c are gated by
>>> "#ifdef CONFIG_CMD_NET". That's why I say it could be another way.
>>
>> OK, sure... but that breaks intended behavior, I think.
>>
> 
> I see. The CONFIG_CMD_NET is not evaluated separated for SPL build. So I guess
> the fix can be either to put the common function in header file after making it
> really simple to reduce dependency, or to keep the original code in env_flag.c.
> 

Codrin,

Can you prepare a new patch? You don't have to send the whole set. All but one
have been acked by Joe.

York