[U-Boot] [PATCH v6 5/5] usb: lpc32xx: add host USB driver

[Vladimir Zapolskiy]

Hi Sylvain,

On 12.08.2015 23:00, LEMIEUX, SYLVAIN wrote:
> Hi Vladimir and Marek,
> 
>> -----Original Message-----
>> From: Vladimir Zapolskiy [mailto:vz at mleia.com]
>> Sent: 12-Aug-15 1:55 PM
>>
>> Hi Sylvain,
>>
>> On 10.08.2015 15:16, slemieux.tyco at gmail.com wrote:
>>> From: Sylvain Lemieux <slemieux at tycoint.com>
>>>
>>> Incorporate USB driver from legacy LPCLinux NXP BSP.
>>> The files taken from the legacy patch are:
>>> - lpc32xx USB driver
>>> - lpc3250 header file USB registers definition.
>>>
>>> The legacy driver was updated and clean-up as part of the integration with the latest u-boot.
>>>
>>> Signed-off-by: Sylvain Lemieux <slemieux at tycoint.com>
>>> ---

[snip]

>>> +   }
>>> +
>>> +   /* Configure ISP1301 */
>>> +   isp1301_configure();
>>
>> Not sure if there are any LPC32xx boards with USB host/device, but
>> without ISP1301 phy. Let it be here until such a board emerges, if Marek
>> does not object.
>>
>> In general I wonder, won't drivers/usb/phy/ be a better place for this
>> driver or bigger part of it?
> 
> The Embedded Artists LPC3250 OEM Board is having the USB with the ISP1301;
> http://www.embeddedartists.com/products/kits/lpc3250_kit.php
> The legacy NXP LPC32xx BSP included board support files for it.
> 

it seems to be a usual design pattern, my devkit3250 board also has
ISP1301 phy. The question is if fusion of a particular external phy
device driver and a particular host device driver are permitted in form
of a host driver only.

This is a question in area of device driver(s) maintenance, therefore
Marek should rule it. For me as a user I'm satisfied with the approach,
when on-SoC host device and external phy device share one driver for
both. Just when an LPC32xx powered board with USB emerges without
ISP1301 phy or other way round ISP1301 phy is used in junction with
another host/device, this time the driver will be split.

--
With best wishes,
Vladimir