[U-Boot] [U-Boot, RESEND, v5] mtd/nand/ubi: assortment of alignment fixes

Marcel Ziswiler marcel at ziswiler.com
Thu Aug 13 09:52:35 CEST 2015


On Wed, 2015-08-12 at 15:43 -0400, Tom Rini wrote:
> On Wed, Aug 05, 2015 at 05:17:04PM +0200, Marcel Ziswiler wrote:
> 
> > From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > 
> > Various U-Boot adoptions/extensions to MTD/NAND/UBI did not take 
> > buffer
> > alignment into account which led to failures of the following form:
> > 
> > ERROR: v7_dcache_inval_range - start address is not aligned - 
> > 0x1f7f0108
> > ERROR: v7_dcache_inval_range - stop address is not aligned - 
> > 0x1f7f1108
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > Acked-by: Scott Wood <scottwood at freescale.com>
> 
> This change causes a huge number of boards to fail to build due to 
> some
> hidden #define games.  The actual error message doesn't provide 
> helpful
> context but building for say "spear300" will show the problem. 


Uups, I see your point. I guess one should not include regular header
files like malloc.h in assembler .S files (;-p). I will send a v6 which
will wrap my wrapper in __ASSEMBLY__ which fixes this.

>  Thanks!

You are very welcome.


More information about the U-Boot mailing list