[U-Boot] [PATCH v3] net: TFTP: add timer count environment variable

Albert ARIBAUD albert.aribaud at 3adev.fr
Thu Aug 13 10:32:09 CEST 2015


Hi Joe,

Le Wed, 12 Aug 2015 12:39:46 -0500, Joe Hershberger
<joe.hershberger at gmail.com> a écrit :

> Hi Albert,
> 
> On Sun, Jul 26, 2015 at 4:53 PM, Albert ARIBAUD (3ADEV)
> <albert.aribaud at 3adev.fr> wrote:
> > There already is an environment variable 'tftptimeout'
> > for setting individuabl block query timeout value, but
> > there is none for setting the maximum TFTP timeout count,
> > which can also help with unreliable network, TFTP server,
> > or client hardware.
> >
> > Add environment variable 'tftptimeoutcountmax'. As per the
> > comments about the global variable tftp_timeout_count_max,
> > make sure tftptimeoutcountmax is nonnegative.
> >
> > Signed-off-by: Albert ARIBAUD (3ADEV) <albert.aribaud at 3adev.fr>
> 
> This patch seems to break the bf527-ezkit target. Just a bit too much code.
> 
> +(bf527-ezkit)   actual: 262240 bytes
> +(bf527-ezkit)   excess: 96 bytes
> 
> Anything you can do? Maybe Sonic has some advise or can recommend
> something else to disable on blackfin. These targets are fairly
> tedious because they are always so close to breaking for any little
> reason.

Hmm... I'll see if I can rewrite the patch, but seeing as it is fairly
simple, it might require drastic change like not warning if going below
the RFC's 1000 ms limit.

> -Joe

Cordialement,
Albert ARIBAUD
3ADEV


More information about the U-Boot mailing list