[U-Boot] [U-BOOT PATCH v3 0/4] x86: This series adds ACPI support for qemu targets.

[Bin Meng]

Hi Saket,

On Thu, Aug 13, 2015 at 11:00 AM, Saket Sinha <saket.sinha89 at gmail.com> wrote:
>
> ACPI(Advanced Configuration and Power Interface), a Power Management and configuration standard allowing the operating system to control    the amount of power each device is given (allowing it to put certain devices on standby or power-off for example). It is also used to control and/or check thermal zones (temperature sensors, fan speeds, etc), battery levels, PCI IRQ routing, CPUs, NUMA domains and many other things.
>
> To begin using ACPI, the operating system must look for the RSDP (Root System Description Pointer). If the RSDP is found, the verification  is valid, it contains a pointer to the RSDT (Root System Description Table) and XSDT (extended System Description Table). For the run time part of ACPI the main table to detect is the FADT (Fixed ACPI Description Table) as this contains information needed to enable ACPI. The DSDT table  contains a bytecode that is executed by a driver in the kernel.
>

I've only finished reviewing the first 2 patches today. Some general
comments regarding to this patch set:

- Some of my previous comments against v1/v2 series are not completely
addressed. I still see them in this v3.
- There are building warnings of qemu with this patch
- There are lots of coding convention issues here and there like 80
cols. Can you please make sure before you submit the patch, run patman
or checkpatch.pl to make sure it is in a good shape?

> Changes from v2:
> - Fixes issues with using MMCONFIG for q35.
> - Fixes various entries in ACPI tables that OS was not able to parse.
>
> Changes from v1:
> - Dynamic generation of AML code for DSDT table.
> -Reading PCI registers for FADT table.
> -Incorporated review comments.
>

Regards,
Bin