[U-Boot] [PATCH] ARM: OMAP5+: configs: Fix default boot command

[Nishanth Menon]

On 08/13/2015 09:56 AM, Lokesh Vutla wrote:
> The default boot command searches for dofastboot varaiable
> and does a fastboot if it is set to 1.
> But the condition "if test ${dofastboot} -eq 1" always
> returns true if dofastboot is not defined and breaking mmc boot.
> So make dofastboot as 0 by default and let the runtime
> environment set it if fastboot is required.
> 
> Reported-by: Yan Liu <yan-liu at ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
> ---
>  include/configs/ti_omap5_common.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h
> index fe04692..1c1f8c0 100644
> --- a/include/configs/ti_omap5_common.h
> +++ b/include/configs/ti_omap5_common.h
> @@ -79,6 +79,7 @@
>  	"vram=16M\0" \
>  	"partitions=" PARTS_DEFAULT "\0" \
>  	"optargs=\0" \
> +	"dofastboot=0\0" \
>  	"mmcdev=0\0" \
>  	"mmcroot=/dev/mmcblk0p2 rw\0" \
>  	"mmcrootfstype=ext4 rootwait\0" \
> 
arch/arm/cpu/armv7/omap-common/boot-common.c sets it to one. so what is
the point of this? dra7_evm defines  CONFIG_USB_FUNCTION_FASTBOOT -> so
it is setting up dofastboot blindly.

Is'nt fixing the source of the issue a better thing to do than depending
on env default -a hoping to save us (which btw will only help opentest
farm).

Looks like the code blindly assumes fastboot mode - which is weird!

-- 
Regards,
Nishanth Menon