[U-Boot] [PATCH v2 3/6] net: e1000: Convert to driver model

[Simon Glass]

Hi Joe,

On 11 August 2015 at 11:33, Joe Hershberger <joe.hershberger at gmail.com> wrote:
> Hi Simon,
>
> On Tue, Aug 11, 2015 at 12:17 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Joe,
>>
>> On 11 August 2015 at 09:53, Joe Hershberger <joe.hershberger at gmail.com> wrote:
>>> Hi Simon,
>>>
>>> On Tue, Aug 11, 2015 at 8:39 AM, Simon Glass <sjg at chromium.org> wrote:
>>>> Update this driver to support driver model.
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> ---
>>>
>>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>>>
>>> ...but a few nits below.
>>>
>>>>
>>>> Changes in v2: None
>>>>
>>>>  drivers/net/e1000.c | 137 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>  drivers/net/e1000.h |   4 ++
>>>>  2 files changed, 141 insertions(+)
>>>>

[snip]

>>>> diff --git a/drivers/net/e1000.h b/drivers/net/e1000.h
>>>> index bfacd4e..543459d 100644
>>>> --- a/drivers/net/e1000.h
>>>> +++ b/drivers/net/e1000.h
>>>> @@ -22,7 +22,9 @@
>>>>  #include <linux/list.h>
>>>>  #include <malloc.h>
>>>>  #include <net.h>
>>>> +#ifndef CONFIG_DM_ETH
>>>>  #include <netdev.h>
>>>> +#endif
>>>
>>> Is there a need to not include this in the DM case? Or are you just
>>> trying to document what should be removed when !DM is purged?
>>> Typically I would not #ifdef an include.
>>
>> I gives a build error at present.
>
> OK. I guess it would be good to know what the error is and if it's
> easily addressable.
>

struct eth_device is referenced in netdev.h. I'll add a comment.

[snip]

Regards,
Simon