[U-Boot] [PATCH V2 00/10] Replace the FAT filesystem code

[Stephen Warren]

On 08/12/2015 08:56 PM, Simon Glass wrote:
> Hi Stephen,
> 
> On 11 August 2015 at 08:55, Stephen Warren <swarren at wwwdotorg.org> wrote:
>> The existing FAT filesystem implementation in U-Boot has some bugs that
>> are tricky to fix cleanly without significant rework of the code. For
>> example, see:
>>
>> http://lists.denx.de/pipermail/u-boot/2015-July/221054.html
>> [PATCH] fat: handle paths that include ../
>>
>> This series replaces U-Boot's FAT filesystem implementation with the "ff"
>> project; http://elm-chan.org/fsw/ff/00index_e.html. This project appears
>> to be actively maintained, does not have at least the bug referenced in
>> the patch link above, and is quite easy to integrate into U-Boot. An
>> earlier version is also used in Barebox, so presumably it's had some
>> level of testing/exposure there.
>>
> 
> This seems like a good idea to me. Are there some standard tests for
> FAT that we can bring in also? Perhaps using sandbox? At present we
> have fs-test.sh which is a start.

This series does pass fs-test.sh, which caught a couple of bugs. It
would be nice to ensure that the image fs-test.sh creates cause all of
FAT12/16/32 to be parsed. It'd also be nice to extend it with a check
for the bug that triggered me to start fiddling with FAT; /foo/../xxx
where xxx is past the first sector (cluster?) of the root directory. We
could likely test for volume ID retrieval, ls output, ... too. Many
options to extend the test; all will take time though.