[U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x

Marcel Ziswiler marcel at ziswiler.com
Sun Aug 16 03:13:15 CEST 2015


On Sun, 2015-08-16 at 02:57 +0200, Marek Vasut wrote:

> > Apart from the missing commit message.
> > 
> > Signed-off-by: Marcel Ziswiler <marcel at ziswiler.com>
> 
> I think you're misunderstanding the meaning of a SoB line here, the
> SoB
> line is a certificate of origin. You didn't write the driver and/or
> you
> didn't make changes to it, so you don't place your certificate on it
> :)

Yeah, it's kind of late. Should have been an Acked-by of course, sorry.

> > Tested-by: Marcel Ziswiler <marcel at ziswiler.com>
> 
> This one is of course good.
> 
> > Tested-on: Colibri PXA270 V1.2C, V1.2D, V2.2B, V2.4A on Colibri
> 
> Is this some kind of a newly invented tag ? :-)

Well, others have been using that one on and off for a while. So at
least I am not the inventor (;-p).

> > Evaluation Board V3.1A
> > Note: While power I2C works on the older V1.2C version it does not
> seem
> > to work on any of the newer ones but this might just be a pin
> muxing
> > resp. missing pull up issue.
> 
> Very nice. Btw. how do you bootstrap those modules, do you use that
> OpenPXA
> OBM or OBM2 or something else entirely ?

No, I never used any of that crap. Just purely U-Boot even on the
PXA3xx but the PXA270 being just a regular NOR beast is really nothing
special. Just using ye olde BDI2000 if things go awry. Unfortunately my
PXA3xx U-Boot NAND SPL stuff never made it mainline and you since
dropped PXA3xx support entirely. If I ever get some precious time I
might actually re-add those again especially now with Marvell having
committed to keep selling us PXA320 chips to 2020.


More information about the U-Boot mailing list