[U-Boot] [PATCH V2 4/5] dm9000: dm9000_initialize stub

[Marcel Ziswiler]

On Sun, 2015-08-16 at 02:51 +0200, Marcel Ziswiler wrote:
> On Wed, 2015-08-12 at 12:24 -0500, Andrew Ruder wrote:
> 
> Just one nitty-gritty detail:
> 
> > diff --git a/include/configs/colibri_pxa270.h
> > b/include/configs/colibri_pxa270.h
> > index e3f0ab0..e7db8cf 100644
> > --- a/include/configs/colibri_pxa270.h
> > +++ b/include/configs/colibri_pxa270.h
> > @@ -67,6 +67,7 @@
> >  #define CONFIG_DM9000_BASE		0x08000000
> >  #define DM9000_IO			(CONFIG_DM9000_BASE)
> >  #define DM9000_DATA			(CONFIG_DM9000_BASE +
> > 4)
> > +#define DM9000_HAS_SROM			1
> 
> Colibri PXA270 do not actually have any SROM so this should be
> defined
> to 0 instead.
> 
> >  #define	CONFIG_NET_RETRY_COUNT		10
> 
> Otherwise for the whole series.
> 
> Signed-off-by: Marcel Ziswiler <marcel at ziswiler.com>

This should of course have been an Acked-by, sorry. Will by you some
Guinness in Dublin (;-p).

> Tested-by: Marcel Ziswiler <marcel at ziswiler.com>
> Tested-on: Colibri PXA270 V1.2C, V1.2D, V2.2B, V2.4A on Colibri
> Evaluation Board V3.1A
> Note: I only tested the one default on-module Ethernet instance and
> while it all still works OK it feels like the transfer speed is
> slightly lower (e.g. from the previous 1.3 MiB/s I now get 1.2 
> MiB/s).