[U-Boot] [PATCH 08/11] x86: Only include cbfs command for coreboot

Bin Meng bmeng.cn at gmail.com
Mon Aug 17 03:25:45 CEST 2015


Hi Simon,

On Mon, Aug 17, 2015 at 5:27 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 13 August 2015 at 01:29, Bin Meng <bmeng.cn at gmail.com> wrote:
>> When running U-Boot bare-metal, the cbfs command is useless.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  include/configs/x86-common.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
>> index 349b06c..3d07cc0 100644
>> --- a/include/configs/x86-common.h
>> +++ b/include/configs/x86-common.h
>> @@ -87,7 +87,9 @@
>>  #define CONFIG_ISO_PARTITION           /* Experimental */
>>
>>  #define CONFIG_CMD_PART
>> +#ifdef CONFIG_SYS_COREBOOT
>>  #define CONFIG_CMD_CBFS
>> +#endif
>>  #define CONFIG_CMD_EXT4
>>  #define CONFIG_CMD_EXT4_WRITE
>>  #define CONFIG_PARTITION_UUIDS
>> --
>> 1.8.2.1
>>
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> We should move that to Kconfig. Have you tried Masahiro's moveconfig script?
>

I haven't got a chance to try moveconfig scripts, but I will try some
time. I believe there are lots of work to get all config.h defines
converted to Kconfig options first, and some day we will achieve this
:)

Regards,
Bin


More information about the U-Boot mailing list