[U-Boot] [PATCH v3 2/7] armv8: Add SMC calls infrastructure

[Simon Glass]

Hi Sergei,

On 14 August 2015 at 19:45, Sergei Temerkhanov <s.temerkhanov at gmail.com> wrote:
> On Fri, Aug 14, 2015 at 9:56 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi,
>>
>> On 13 August 2015 at 09:14, Sergey Temerkhanov <s.temerkhanov at gmail.com> wrote:
>>> This commit adds functions issuing calls to firmware. This allows
>>> to use services such as PSCI provided by firmware, e.g. ATF
>>
>> What is PSCI? ATF? SMC? What firmware? Please try to make your commit
>> message more helpful to people trying to understand the code you are
>> adding.
>>
>
> These abbreviations have been introduced by ARM and are used in their
> docs. These
> functions basically issue calls to the secure monitor (SMC) or
> hypervisor (HVC). PSCI
> is the Power State Coordination Interface and ATF is ARM Trusted Firmware. SMC/
> HVC calls conform to the Calling Convention specification. I'll add
> the comments to the
> next version of this patch

OK thanks. I think it is good to spell out abbreviations in Kconfig or
header files (e.g. the first time they are used).

Regards,
Simon